Improves objective. Closes #229 #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/docker-introduction/compare/md-outputs..md-outputs-PR-247 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-08-16 09:40:08 +0000 |
jcohen02
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
LGTM.
I note a warning also appearing in the diff on an unrelated line where there's the link to profiles.html, saying that the file doesn't exist. This file is generated as part of the build process. I was under the impression from the workbench docs that the link could be to profiles.md, which does exist, and then the links are updated during the build process when the pages are generated, however, this didn't seem to be working for some reason.
github-actions bot
pushed a commit
to jcohen02/docker-introduction
that referenced
this pull request
Oct 21, 2024
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request carpentries-incubator#247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes carpentries-incubator#229
github-actions bot
pushed a commit
to jcohen02/docker-introduction
that referenced
this pull request
Oct 21, 2024
Auto-generated via `{sandpaper}`
Source : 808d474
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-21 21:39:36 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request carpentries-incubator#247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes carpentries-incubator#229
github-actions bot
pushed a commit
to jcohen02/docker-introduction
that referenced
this pull request
Oct 22, 2024
Auto-generated via `{sandpaper}`
Source : 808d474
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-21 21:39:36 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request carpentries-incubator#247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes carpentries-incubator#229
github-actions bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request #247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes #229
github-actions bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Auto-generated via `{sandpaper}`
Source : 6956a76
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-22 01:42:25 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request #247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes #229
github-actions bot
pushed a commit
to jcohen02/docker-introduction
that referenced
this pull request
Oct 29, 2024
Auto-generated via `{sandpaper}`
Source : 808d474
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-21 21:39:36 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request carpentries-incubator#247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes carpentries-incubator#229
github-actions bot
pushed a commit
to jcohen02/docker-introduction
that referenced
this pull request
Nov 5, 2024
Auto-generated via `{sandpaper}`
Source : 808d474
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-21 21:39:36 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request carpentries-incubator#247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes carpentries-incubator#229
github-actions bot
pushed a commit
to jcohen02/docker-introduction
that referenced
this pull request
Nov 12, 2024
Auto-generated via `{sandpaper}`
Source : 808d474
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-21 21:39:36 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request carpentries-incubator#247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes carpentries-incubator#229
github-actions bot
pushed a commit
to jcohen02/docker-introduction
that referenced
this pull request
Nov 19, 2024
Auto-generated via `{sandpaper}`
Source : 808d474
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-21 21:39:36 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request carpentries-incubator#247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes carpentries-incubator#229
github-actions bot
pushed a commit
to jcohen02/docker-introduction
that referenced
this pull request
Nov 26, 2024
Auto-generated via `{sandpaper}`
Source : 808d474
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-21 21:39:36 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request carpentries-incubator#247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes carpentries-incubator#229
github-actions bot
pushed a commit
to jcohen02/docker-introduction
that referenced
this pull request
Dec 3, 2024
Auto-generated via `{sandpaper}`
Source : 808d474
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-21 21:39:36 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request carpentries-incubator#247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes carpentries-incubator#229
github-actions bot
pushed a commit
to jcohen02/docker-introduction
that referenced
this pull request
Dec 10, 2024
Auto-generated via `{sandpaper}`
Source : 808d474
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-21 21:39:36 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request carpentries-incubator#247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes carpentries-incubator#229
github-actions bot
pushed a commit
to jcohen02/docker-introduction
that referenced
this pull request
Dec 17, 2024
Auto-generated via `{sandpaper}`
Source : 808d474
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-21 21:39:36 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 79a2f1a
Branch : main
Author : Andy Turner <[email protected]>
Time : 2024-10-12 18:26:43 +0000
Message : Merge pull request carpentries-incubator#247 from aturner-epcc/aturner-epcc/objective-i229
Improves objective. Closes carpentries-incubator#229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement to objective wording as suggested by reviewer. Closes #229